Update mock to test devfile with private parent#192
Merged
maysunfaisal merged 2 commits intodevfile:mainfrom Dec 6, 2023
Merged
Update mock to test devfile with private parent#192maysunfaisal merged 2 commits intodevfile:mainfrom
maysunfaisal merged 2 commits intodevfile:mainfrom
Conversation
Signed-off-by: Maysun J Faisal <[email protected]>
782abcd to
c36a9fa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 60.56% 60.42% -0.14%
==========================================
Files 43 43
Lines 5061 5097 +36
==========================================
+ Hits 3065 3080 +15
- Misses 1806 1828 +22
+ Partials 190 189 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maysun J Faisal <[email protected]>
3 tasks
johnmcollier
approved these changes
Dec 6, 2023
kim-tsao
approved these changes
Dec 6, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnmcollier, kim-tsao, maysunfaisal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Updates:
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Unit/Functional tests
QE Integration test
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Tests should pass