parse parent devfile from devfile registry#63
Merged
yangcao77 merged 10 commits intodevfile:masterfrom Mar 12, 2021
Merged
Conversation
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
…rent-from-registry
…rent-from-registry
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
…rent-from-registry
Signed-off-by: Stephanie <[email protected]>
Member
maysunfaisal
left a comment
maysunfaisal
left a comment
There was a problem hiding this comment.
We should demo this to Elson before merging it and see if this is what is expected.
Also should should we do plugin.Id? Its weird to have plugin and parent uri but only parent id in the main branch. The PR to remove plugin is still a WIP.
Signed-off-by: Stephanie <[email protected]>
yangcao77
force-pushed
the
354-parse-parent-from-registry
branch
from
f158c53 to
c289f59
Compare
Signed-off-by: Stephanie <[email protected]>
maysunfaisal
approved these changes
Mar 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie [email protected]
What does this PR do?
This PR adds support to pull & parse parent devfile from devfile registry.
Details can be found in: devfile/api#354
This PR deprecates the existing parser functions, and created a new one
ParseDevfile()which accept a struct as param.What issues does this PR fix or reference?
Fixes devfile/api#354
Fixes devfile/api#369
Is your PR tested? Consider putting some instruction how to test your changes
Added unit tests