concurrent URImap read and writes#66
Merged
yangcao77 merged 5 commits intodevfile:masterfrom Mar 4, 2021
Merged
Conversation
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
0325224 to
5d8d5bd
Compare
Signed-off-by: Stephanie <[email protected]>
5d8d5bd to
03d1eb5
Compare
Merged
Signed-off-by: Stephanie <[email protected]>
maysunfaisal
approved these changes
Mar 4, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves the concurrency issue with URIMap. It removes the global URIMap defined in context.go, and save it in each devfileObj's cxt.
What issues does this PR fix or reference?
Fixes devfile/api#359
Is your PR tested? Consider putting some instruction how to test your changes
@mmulholla helped test with API tests, can run 20 consecutive runs without failure