enable test coverage + upload results in workflow#91
Merged
kim-tsao merged 3 commits intodevfile:masterfrom Jun 1, 2021
Merged
enable test coverage + upload results in workflow#91kim-tsao merged 3 commits intodevfile:masterfrom
kim-tsao merged 3 commits intodevfile:masterfrom
Conversation
Member
maysunfaisal
left a comment
There was a problem hiding this comment.
Nice, tried it out and works well 👍
Two questions:
- should we add the generated html to gitignore
- how do you access the coverage html file from the workflow tests
Contributor
Author
Good point, I just updated the file.
It'll show up as a downloadable artifact under the summary page |
Member
pretty cool |
maysunfaisal
approved these changes
May 31, 2021
maysunfaisal
approved these changes
Jun 1, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated the go test command in the Makefile to include test coverage and report generation. The go.yml was also updated to upload the test coverage report as a workflow artifact. There was a minor fix where the originally command was missing the -v flag and so the details of the test cases (PASS/FAIL) were not being reported
What issues does this PR fix or reference?
devfile/api#470
Is your PR tested? Consider putting some instruction how to test your changes
I ran the Makefile locally