Add mock func for DevfileData interface#93
Conversation
|
Should the mock_interface be under testingutil pkg, instead of our production pkg? |
|
@yangcao77 its usually kept in the same dir as the interface file. Thats the practice that I saw in online examples and odo as our close reference. I'll check more tho, brb |
Reasonable. If we have new interface for v3 in the future, we need to create matching mock funcs for new interface anyways. |
Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
|
Another thought on this PR: |
Signed-off-by: Maysun J Faisal <[email protected]>
yangcao77
left a comment
yangcao77
left a comment
There was a problem hiding this comment.
changes look good to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Signed-off-by: Maysun J Faisal [email protected]
What does this PR do?
Adds mock funcs for the DevfileData interface via the mockgen tool
What issues does this PR fix or reference?
Fixes devfile/api#383
Is your PR tested? Consider putting some instruction how to test your changes
Yes, updated tests to use the mock data