Merged
Conversation
Member
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@ehsavoie your commit needs a sign off to pass the DCO check
Updating the tags and the description Signed-off-by: Emmanuel Hugonnet <[email protected]>
Collaborator
Author
|
@michael-valdron Sorry I did it 'online'. Should be fixed now |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehsavoie, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
There was a tiny impact on alizer's ci job. In general I think we are ok and we only need to update the ci job in order to handle the update in the tags. I've opened devfile/api#1248 in order to track this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the tags and the description
What does this PR do?:
Updating the tags and the description