Skip to content

gosec enablement#27

Merged
kim-tsao merged 4 commits intodevfile:mainfrom
kim-tsao:gosec
Oct 11, 2022
Merged

gosec enablement#27
kim-tsao merged 4 commits intodevfile:mainfrom
kim-tsao:gosec

Conversation

@kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Oct 5, 2022

Signed-off-by: Kim Tsao [email protected]

Please specify the area for this PR

What does does this PR do / why we need it:

  • enables gosec in githubs actions
  • adds rule to Makefile

Which issue(s) this PR fixes:

Fixes #?

devfile/api#937
PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation

How to test changes / Special notes to the reviewer:

@kim-tsao
gosec enablement
02a78a3 
Signed-off-by: Kim Tsao <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 24.33% // Head: 23.52% // Decreases project coverage by -0.80% ⚠️

Coverage data is based on head (0bb1fa0) compared to base (eb2c2f0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   24.33%   23.52%   -0.81%     
==========================================
  Files          22       22              
  Lines        1052     1054       +2     
==========================================
- Hits          256      248       -8     
- Misses        787      795       +8     
- Partials        9       11       +2
Impacted Files Coverage Δ
controllers/devfileregistry_controller.go 0.00% <0.00%> (ø)
pkg/registry/configmap.go 0.00% <0.00%> (ø)
pkg/registry/deployment.go 0.00% <0.00%> (ø)
pkg/registry/ingress.go 0.00% <0.00%> (ø)
pkg/registry/route.go 0.00% <0.00%> (ø)
pkg/registry/service.go 0.00% <0.00%> (ø)
pkg/registry/volume.go 0.00% <0.00%> (ø)
controllers/devfileregistrieslist_controller.go 78.57% <0.00%> (-14.29%) ⬇️
...rollers/clusterdevfileregistrieslist_controller.go 78.57% <0.00%> (-14.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kim-tsao
fix gosec errors
691b5b3 
Signed-off-by: Kim Tsao <[email protected]>
@kim-tsao
fix gosec warnings
2257704 
Signed-off-by: Kim Tsao <[email protected]>
@kim-tsao kim-tsao mentioned this pull request Oct 7, 2022
Closed
4 tasks
@kim-tsao kim-tsao marked this pull request as ready for review October 7, 2022 14:52
@kim-tsao kim-tsao requested a review from johnmcollier October 7, 2022 14:52
@openshift-ci openshift-ci bot added the lgtm label Oct 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao
fix integration tests
0bb1fa0 
Signed-off-by: Kim Tsao <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

New changes are detected. LGTM label has been removed.

@kim-tsao kim-tsao merged commit 07d69b2 into devfile:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnmcollier johnmcollier johnmcollier approved these changes

Assignees

@johnmcollier johnmcollier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kim-tsao @johnmcollier