Skip to content

update palantirJavaFormat for Java 21#1822

Closed
slachiewicz wants to merge 2 commits intodiffplug:mainfrom
slachiewicz:java21
Closed

update palantirJavaFormat for Java 21#1822
slachiewicz wants to merge 2 commits intodiffplug:mainfrom
slachiewicz:java21

Conversation

@slachiewicz
Copy link
Contributor

@slachiewicz slachiewicz commented Sep 21, 2023

Based on @basil user report and fix #1774

@gortiz gortiz mentioned this pull request Sep 22, 2023
Closed
7 tasks
@slawekjaranowski slawekjaranowski mentioned this pull request Sep 23, 2023
Merged
@gortiz gortiz mentioned this pull request Sep 25, 2023
Merged
HTHou
HTHou reviewed Sep 26, 2023
View reviewed changes
slawekjaranowski
slawekjaranowski reviewed Sep 28, 2023
View reviewed changes
@nedtwigg nedtwigg changed the title Fix to run with Java 21 update palantirJavaFormat for Java 21 Sep 28, 2023
@nedtwigg nedtwigg mentioned this pull request Sep 28, 2023
Closed
1 task
@nedtwigg
Copy link
Member

nedtwigg commented Sep 28, 2023

Looks like issues around gradle variants.

 project : > com.palantir.javaformat:palantir-java-format:2.38.0 > com.palantir.javaformat:palantir-java-format-spi:2.38.0

  Caused by: org.gradle.internal.component.AmbiguousConfigurationSelectionException: The consumer was configured to find attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external'. However we cannot choose between the following variants of com.google.guava:guava:32.1.2-jre:
    - androidRuntimeElements
    - jreRuntimeElements
  All of them match the consumer attributes:
    - Variant 'androidRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'android' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
    - Variant 'jreRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'standard-jvm' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
      at app//com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)

We had similar issues in #1808

@nedtwigg
Copy link
Member

nedtwigg commented Sep 29, 2023

FYI, main is now on Gradle 8.4, so if you want to bring Java 21 back into the test matrix, that would be welcome. I don't think it will help with the variant issue above though...

@slachiewicz slachiewicz marked this pull request as draft September 29, 2023 18:47
@slachiewicz
Copy link
Contributor Author

slachiewicz commented Sep 29, 2023

Unfortunately, it's still the same error with the new Gradle - no idea how to fix this dependency issue.

@nedtwigg nedtwigg marked this pull request as ready for review November 2, 2023 00:24
@nedtwigg
Copy link
Member

nedtwigg commented Nov 2, 2023

Anyone know why this PR isn't running CI? It's doing spotlessCheck assemble testClasses but none of the actual testrunner runs...

@nedtwigg
Copy link
Member

nedtwigg commented Nov 16, 2023 

  org.gradle.api.artifacts.ResolveException: Could not resolve all dependencies for [com.palantir.javaformat:palantir-java-format:2.38.0].
      at com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)
  Caused by: org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':detachedConfiguration1'.
      at app//com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)
  Caused by: org.gradle.internal.resolve.ModuleVersionResolveException: Could not resolve com.google.guava:guava:32.1.2-jre.
  Required by:
      project : > com.palantir.javaformat:palantir-java-format:2.38.0
      project : > com.palantir.javaformat:palantir-java-format:2.38.0 > com.palantir.javaformat:palantir-java-format-spi:2.38.0

  Caused by: org.gradle.internal.component.AmbiguousConfigurationSelectionException: The consumer was configured to find attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external'. However we cannot choose between the following variants of com.google.guava:guava:32.1.2-jre:
    - androidRuntimeElements
    - jreRuntimeElements
  All of them match the consumer attributes:
    - Variant 'androidRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'android' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
    - Variant 'jreRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'standard-jvm' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
      at app//com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)

@Goooler Goooler mentioned this pull request Nov 27, 2023
Closed
@Goooler
Copy link
Member

Goooler commented Nov 28, 2023 •
edited
Loading

@slachiewicz Seems I've fixed the dependency resolving issue, you can ref Goooler#12. And if you wanna run CI on Java 21, still need to fix GJF tests. You may just add .add(21, "2.38.0") but 073a762.

@StefanLobbenmeierObjego
Copy link

StefanLobbenmeierObjego commented Nov 30, 2023 •
edited
Loading

FYI with gradle 8.5 being released today this became more urgent as it blocks users from running gradle on java 21

I could confirm that manually setting the version works for me though (as also shown in this comment: palantir/palantir-java-format#943 (comment))

@Goooler
Copy link
Member

Goooler commented Nov 30, 2023

I was planning to fix Java 21 compatibility issues for Gradle, we can probably fix Maven first.

@steven-sheehy
Copy link
Contributor

steven-sheehy commented Nov 30, 2023

@Goooler Is it possible to submit your changes as a separate PR if it's passing CI since this one doesn't seem to see any updates?

@steven-sheehy steven-sheehy mentioned this pull request Nov 30, 2023
Merged
2 tasks
@Goooler Goooler mentioned this pull request Dec 1, 2023
Merged
@Goooler
Copy link
Member

Goooler commented Dec 1, 2023

It's in #1920.

@nedtwigg
Copy link
Member

nedtwigg commented Dec 3, 2023

@nedtwigg nedtwigg closed this Dec 3, 2023
@nedtwigg
Copy link
Member

nedtwigg commented Dec 4, 2023

Published in plugin-gradle 6.23.3 and plugin-maven 2.41.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

@HTHou HTHou HTHou left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update default versions for palantir-java-format

7 participants

@slachiewicz @nedtwigg @Goooler @StefanLobbenmeierObjego @steven-sheehy @slawekjaranowski @HTHou