Reuse configs for KotlinExtension and KotlinGradleExtension#1890
Merged
nedtwigg merged 3 commits intodiffplug:mainfrom Nov 20, 2023
Merged
Reuse configs for KotlinExtension and KotlinGradleExtension#1890nedtwigg merged 3 commits intodiffplug:mainfrom
KotlinExtension and KotlinGradleExtension#1890nedtwigg merged 3 commits intodiffplug:mainfrom
Conversation
Member
Author
Goooler
changed the title
KotlinFormatExtension to KtlintFormatExtensionKotlinExtension and KotlinGradleExtension
This comment was marked as outdated.
This comment was marked as outdated.
Goooler
force-pushed
the
rename-kt-format-extension
branch
from
5a0afce to
4597085
Compare
Goooler
changed the title
KotlinExtension and KotlinGradleExtensionKotlinExtension and KotlinGradleExtension
Goooler
commented
Nov 19, 2023
Comment on lines
-41
to
+24
| public class KotlinExtension extends FormatExtension implements HasBuiltinDelimiterForLicense, JvmLang { | ||
| public class KotlinExtension extends BaseKotlinExtension implements HasBuiltinDelimiterForLicense, JvmLang { |
Member
Author
There was a problem hiding this comment.
Should we implement HasBuiltinDelimiterForLicense for KotlinGradleExtension? If so we can move this into BaseKotlinExtension as well.
Member
There was a problem hiding this comment.
Same problem as for Groovy imo.
Goooler
force-pushed
the
rename-kt-format-extension
branch
from
491cad5 to
a392c72
Compare
Member
|
Another nice refactor! |
|
I configure Spotless in my project via a local plugin which is now broken by this refactor:
|
Member
Author
|
This use-case is not been covered by tests, fixing it in #1912. |
This was referenced Dec 2, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KotlinFormatExtensionmight be a typo, renames it.*Config.