imagetools: silence intoto warnings#1549
Merged
tonistiigi merged 1 commit intodocker:masterfrom Jan 25, 2023
Merged
Conversation
thaJeztah
reviewed
Jan 24, 2023
jedevc
force-pushed
the
silence-intoto-warnings
branch
from
4e3e45d to
1ac5783
Compare
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
silence-intoto-warnings
branch
from
1ac5783 to
7145e02
Compare
thaJeztah
approved these changes
Jan 24, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (but more eyes never hurt in case I missed something around the WithMediaTypePrefix() parts 😅)
Member
|
@tonistiigi PTAL |
tonistiigi
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @tonistiigi:
This is the buildx equivalent of moby/buildkit#3063.