Optimise docker stats to not require clearing the whole screen#5625
Merged
thaJeztah merged 1 commit intodocker:masterfrom Nov 19, 2024
Merged
Optimise docker stats to not require clearing the whole screen#5625thaJeztah merged 1 commit intodocker:masterfrom
docker stats to not require clearing the whole screen#5625thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Instead of clearing the whole screen and then writing the new stats, we now write the new stats on top of the old text, and then clear the remaining text. This is a more efficient way to update the stats, as it avoids the flickering that happens when the screen is cleared and rewritten. Signed-off-by: Giedrius Jonikas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5625 +/- ##
==========================================
- Coverage 59.50% 59.49% -0.02%
==========================================
Files 346 346
Lines 29365 29371 +6
==========================================
Hits 17474 17474
- Misses 10916 10922 +6
Partials 975 975
|
laurazard
approved these changes
Nov 18, 2024
Member
laurazard
left a comment
laurazard
left a comment
There was a problem hiding this comment.
LGTM!
I'd like to add some tests/otherwise refactor this area, but that's orthogonal to this PR and this looks safe
Benehiko
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of clearing the whole screen and then writing the new stats, we now write the new stats on top of the old text, and then clear the remaining text.
This is a more efficient way to update the stats, as it avoids the flickering that happens when the screen is cleared and rewritten.
This improves upon #5586