fix/dockerfiles: Update CMD instruction in 'Dockerfile.dev' to use exec form#5742
Conversation
dockerfiles/Dockerfile.dev
Outdated
| && echo -e "cat /etc/motd\nPS1=\"\e[0;32m\u@docker-cli-dev\\$ \e[0m\"" >> /root/.bashrc \ | ||
| && echo -e "source /etc/bash/bash_completion.sh" >> /root/.bashrc | ||
| CMD bash | ||
| CMD ["bash"] |
There was a problem hiding this comment.
This should probably be /bin/bash;
docker run -it --rm alpine
ask add --no-cache bash
command -v bash
/bin/bashThere was a problem hiding this comment.
Thanks! Looks like the second commit is missing a DCO sign-off, which makes CI fail
could you squash both commits (we prefer not to keep history for fix-ups like this), and amend the commit message so that it has a DCO sign-off?
Let me know if you need help doing so!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5742 +/- ##
==========================================
- Coverage 59.51% 59.48% -0.04%
==========================================
Files 346 346
Lines 29376 29367 -9
==========================================
- Hits 17483 17468 -15
- Misses 10923 10926 +3
- Partials 970 973 +3 |
…xec form instead of shell form * https://docs.docker.com/reference/build-checks/json-args-recommended/ Signed-off-by: Mert Şişmanoğlu <[email protected]>
mertssmnoglu
force-pushed
the
fix-dockerfile-exec-form
branch
from
40ce68a to
48dbdc6
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
sorry for the delay! I saw this warning when I built the Dockerfile and thought "didn't we merge a PR for that?" then realising it was still pending 🙈
Thanks for contributing!
4 participants
- What I did
I updated the CMD instruction in the
dockerfiles/Dockerfile.devto prevent theJSONArgsRecommendedbuild check warning.- How I did it
I followed the dockerdocs instructions
- How to verify it
You can run
make devcommand on the master branch, when the build finished successfully it shows a yellowish "JSONArgsRecommended" warning.Once you switch to the
fix-dockerfile-exec-formbranch, and re-runmake devyou will not see anyJSONArgsRecommendedwarning.The expected output:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)