Skip to content

Don't ignore GITHUB_TOKEN#2002

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:gh-token
Mar 9, 2026
Merged

Don't ignore GITHUB_TOKEN#2002
dgageot merged 1 commit intodocker:mainfrom
dgageot:gh-token

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 9, 2026

No description provided.

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot requested a review from a team as a code owner March 9, 2026 12:03
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

The changes remove GITHUB_TOKEN= from the test command environment variable assignments in two tasks (test and test-binary). This allows tests to inherit the GITHUB_TOKEN from the environment instead of explicitly clearing it.

Analysis:

  • The change is intentional and aligns with the PR title "Don't ignore GITHUB_TOKEN"
  • Previously, GITHUB_TOKEN was cleared alongside other API keys to ensure deterministic tests
  • Now tests can access the GitHub token when present in the environment
  • No logic errors, security issues, or resource leaks introduced
  • The modification is minimal and straightforward

Note: This change may affect test behavior if tests rely on GitHub token access. The PR intentionally enables this capability.

Findings

No bugs found in the changed code.


Review performed by docker-agent PR bot

@dgageot dgageot merged commit 52152da into docker:main Mar 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants