Workaround requests resolving our unix socket URL on macosx.#1928
Merged
shin- merged 1 commit intodocker:masterfrom Feb 27, 2018
Merged
Conversation
Author
|
Fixes docker-compose issue docker/compose#3419 |
Signed-off-by: Matthieu Nottale <[email protected]>
mnottale
force-pushed
the
fix-spurious-resolution-macos-slowdown
branch
from
2c2d189 to
15c26e7
Compare
Contributor
|
@mnottale Thanks! You were able to verify that this fixes the issue? |
Author
|
Yes I did using tcpdump. I can confirm no DNS queries with this patch (and one per docker connection without) |
Contributor
|
Cool, thank you! Maybe we'll make a 3.1.1 - this fix will make a lot of people happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthieu Nottale [email protected]