[tests] Remove the last set of ignored MSBuild tests#8246
Merged
pjcollins merged 5 commits intodotnet:mainfrom Aug 9, 2023
Merged
[tests] Remove the last set of ignored MSBuild tests#8246pjcollins merged 5 commits intodotnet:mainfrom
pjcollins merged 5 commits intodotnet:mainfrom
Conversation
Fixes: dotnet#7777 The last set of ignored test categories have been removed or migrated to existing tests: * Test configurations related to AotMode=Hybrid and AotMode=Full have been removed. * BuildTest.CheckSequencePointGeneration has been removed due to it relying on mono symbol output. * EnvironmentContentTests.CheckBuildIdIsUnique has been removed due to it relying on mono symbol output. * PackagingTest.CheckManagedSymbolsArchive has been removed due to it relying on mono symbol output. * InstallAndRunTests.MonoSymbolicateAndroidStackTrace has been removed due to it relying on mono symbol output. * InstallAndRunTests.MonoSymbolicateNetStandardStackTrace has been removed due to it relying on mono symbol output. * EmbeddedDSOTests.BinariesExist removed as it is implicitly covered by tests that validate .apk contents. * EmbeddedDSOTests.EnvironmentFileContents removed as it is covered by BuildTest.CheckAssemblyCounts. * EmbeddedDSOTests.DSOPageAlignment assert moved to PackagingTest.EmbeddedDSOs. * EmbeddedDSOTests.DSOCompressionMode and EmbeddedDSOTests.AndroidManifestHasFlag removed as they are covered by PackagingTest.EmbeddedDSOs.
grendello
approved these changes
Aug 7, 2023
jonathanpeppers
approved these changes
Aug 7, 2023
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Overall, the test changes look good. 👍 Just had the one question.
I guess if mono-symbolicate ever came back, its replacement would probably look a lot different anyway. I don't think we'd even be able to use those tests.
build-tools/automation/yaml-templates/run-sliced-nunit-tests.yaml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7777
The last set of ignored test categories have been removed or migrated to existing tests:
Test configurations related to AotMode=Hybrid and AotMode=Full have been removed.
BuildTest.CheckSequencePointGeneration has been removed due to it relying on mono symbol output.
EnvironmentContentTests.CheckBuildIdIsUnique has been removed due to it relying on mono symbol output.
PackagingTest.CheckManagedSymbolsArchive has been removed due to it relying on mono symbol output.
InstallAndRunTests.MonoSymbolicateAndroidStackTrace has been removed due to it relying on mono symbol output.
InstallAndRunTests.MonoSymbolicateNetStandardStackTrace has been removed due to it relying on mono symbol output.
EmbeddedDSOTests.BinariesExist removed as it is implicitly covered by tests that validate .apk contents.
EmbeddedDSOTests.EnvironmentFileContents removed as it is covered by BuildTest.CheckAssemblyCounts.
EmbeddedDSOTests.DSOPageAlignment assert moved to PackagingTest.EmbeddedDSOs.
EmbeddedDSOTests.DSOCompressionMode and EmbeddedDSOTests.AndroidManifestHasFlag removed as they are covered by PackagingTest.EmbeddedDSOs.