Fix typo in MediaLibraryService method name: OnGetSeesionFromMediaLibraryService -> OnGetSessionFromMediaLibraryService#1198
Merged
jonathanpeppers merged 5 commits intomainfrom Jul 17, 2025
Conversation
…raryService -> OnGetSessionFromMediaLibraryService Co-authored-by: jonathanpeppers <[email protected]>
Copilot
AI
changed the title
[WIP] OnGetSeesionFromMediaLibraryService
Fix typo in MediaLibraryService method name: OnGetSeesionFromMediaLibraryService -> OnGetSessionFromMediaLibraryService
Jul 7, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Co-authored-by: jonathanpeppers <[email protected]>
Member
|
The customer reports a second issue that is still happening: The file in question has the method: public androidx.media3.session.MediaSession onGetSession (androidx.media3.session.MediaSession.ControllerInfo p0)
{
return n_onGetSession (p0);
}
private native androidx.media3.session.MediaSession n_onGetSession (androidx.media3.session.MediaSession.ControllerInfo p0);We think this is caused by: Remove these, and see if we can solve the problem a different way. |
…ediaLibraryService.onGetSession Co-authored-by: jonathanpeppers <[email protected]>
Contributor
Author
Removed the problematic |
jonathanpeppers
approved these changes
Jul 17, 2025
jonathanpeppers
pushed a commit
that referenced
this pull request
Jul 17, 2025
…rvice` typo (#1198) Fixes: #1195 Fixed a typo in the managedName attribute for the `MediaLibraryService.onGetSession` method binding where "Session" was misspelled as "Seesion". This was causing build errors when developers tried to override the method with the correct spelling. ## Problem When developers attempted to override the `OnGetSessionFromMediaLibraryService` method (with correct spelling), they would get Java errors during build. However, using the misspelled version `OnGetSeesionFromMediaLibraryService` would compile but not build properly. ## Solution - Changed `OnGetSeesionFromMediaLibraryService` to `OnGetSessionFromMediaLibraryService` in `/source/androidx.media3/media3-session/Transforms/Metadata.xml` - This is a minimal, single-character fix that corrects the typo without affecting any other functionality - Removed the problematic `managedReturn` and `managedOverride` attributes from lines 56-67 in Metadata.xml. These were forcing the `onGetSession` method to return `MediaSession` instead of the correct `MediaLibrarySession` type, causing the Java compatibility errors. Now developers can properly override the method using the correct spelling: ```csharp public override MediaLibrarySession OnGetSessionFromMediaLibraryService(MediaSession.ControllerInfo controllerInfo) { // Implementation } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a typo in the managedName attribute for the
MediaLibraryService.onGetSessionmethod binding where "Session" was misspelled as "Seesion". This was causing build errors when developers tried to override the method with the correct spelling.Problem
When developers attempted to override the
OnGetSessionFromMediaLibraryServicemethod (with correct spelling), they would get Java errors during build. However, using the misspelled versionOnGetSeesionFromMediaLibraryServicewould compile but not build properly.Solution
OnGetSeesionFromMediaLibraryServicetoOnGetSessionFromMediaLibraryServicein/source/androidx.media3/media3-session/Transforms/Metadata.xmlVerification
dotnet cake --target=metadata-verifyNow developers can properly override the method using the correct spelling:
Fixes #1195.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.