[Mono] move consolerunner instantiation to separate function#15467
Merged
akoeplinger merged 2 commits intodotnet:mainfrom Jan 30, 2025
Merged
[Mono] move consolerunner instantiation to separate function#15467akoeplinger merged 2 commits intodotnet:mainfrom
akoeplinger merged 2 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
cc: @akoeplinger |
saitama951
force-pushed
the
workaround-xunit-mismatch
branch
2 times, most recently
from
9da89ee to
1d33a8d
Compare
This is on platforms where the Mono SDK is supported. When Mono JIT compiles `Main()`, it encounters a call to `new ConsoleRunner()`. Unlike CoreCLR, Mono JIT **attempts to resolve all field types of ConsoleRunner at JIT compilation time**, rather than deferring resolution until runtime. The problem arises because some fields inside `ConsoleRunner` depend on **assemblies that are only resolvable via the assembly resolve event handler**. However, this resolve handler is **only installed after Main() has been compiled and execution starts**. As a result, Mono JIT fails when it attempts to load these types too early, leading to runtime errors. This is a workaround for a limitation in Mono JIT by moving the instantiation to an another function. Allow `Main()` to execute first**, ensuring that the assembly resolve handler is installed **before** `ConsoleRunner` is instantiated see: dotnet/runtime#60550
saitama951
force-pushed
the
workaround-xunit-mismatch
branch
from
1d33a8d to
f0188b7
Compare
ViktorHofer
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on platforms where the Mono SDK is supported.
When Mono JIT compiles
Main(), it encounters a call tonew ConsoleRunner(). Unlike CoreCLR, Mono JIT attempts to resolve all field types of ConsoleRunner at JIT compilation time, rather than deferring resolution until runtime.The problem arises because some fields inside
ConsoleRunnerdepend on assemblies that are only resolvable via the assembly resolve event handler. However, this resolve handler is only installed after Main() has been compiled and execution starts. As a result, Mono JIT fails when it attempts to load these types too early, leading to runtime errors.This is a workaround for a limitation in Mono JIT by moving the instantiation to an another function.
Allow
Main()to execute first**, ensuring that the assembly resolve handler is installed beforeConsoleRunneris instantiatedsee: dotnet/runtime#60550