Merged
Conversation
halter73
commented
Apr 15, 2021
dd8bd1f to
15757e6
Compare
Tratcher
reviewed
Apr 15, 2021
Tratcher
reviewed
Apr 15, 2021
davidfowl
reviewed
Apr 16, 2021
davidfowl
reviewed
Apr 16, 2021
davidfowl
reviewed
Apr 16, 2021
3e827dc to
c788f3b
Compare
Member
Author
|
@Pilchie This is up for API review Monday, but we really want this in preview4. Should we try to merge this today (pending approvals ofc), or wait for API review? |
jkotalik
reviewed
Apr 16, 2021
Member
|
We can retarget it to the Preview 4 branch and still merge on Monday after API review. |
5d77e9e to
eb4ef57
Compare
d114d77 to
1935f76
Compare
1935f76 to
b430995
Compare
pranavkm
reviewed
Apr 19, 2021
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Member
|
FYI, working to unblock the code check with #31982 |
davidfowl
approved these changes
Apr 20, 2021
LadyNaggaga
reviewed
Apr 20, 2021
LadyNaggaga
left a comment
There was a problem hiding this comment.
LGTM - Let's move forward so we can get in the hands of the customers for feedback.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're looking to collect feedback on our new "minimal hosting" API which we will present at BUILD. This adds quite a few types like
WebApplicationandWebApplicationBuilderas minimal alternative toHostandWebHost.We are also planning to update the
dotnet new empty/dotnet new webtemplate for preview4 to use the newWebApplicationtype.For this preview only, this does add temporarily a new
Configuration : IConfigurationRoot, IConfigurationBuildertype to theMicrosoft.AspNetCore.Buildernamespace. I plan to submit a proper API proposal for to introduce this type to theMicrosoft.Extensions.Configurationshortly.Customer Impact
This is entirely new API, so the only impact is giving customers an early preview version of this new minimal hosting API to try out. It does not change any of the existing Hosts so there's no impact to existing apps.
Regression?
Risk
This change merely adds new API to an existing
Microsoft.AspNetCoreassembly.Verification
Packaging changes reviewed?
Addresses #30354
See https://github.com/featherhttp/framework to see the original versions of all of the newly added types.
The new
Configurationtype should be in Microsoft.Extensions as noted in the issue. I plan to open an API proposal to do this tomorrow. I think we'll leave it in the ASP.NET Core shared runtime temporarily for preview4.