Add documentation for ICorProfilerInfo13 methods and enumeration.#30131
Merged
gewarren merged 28 commits intodotnet:mainfrom Jul 29, 2022
Merged
Add documentation for ICorProfilerInfo13 methods and enumeration.#30131gewarren merged 28 commits intodotnet:mainfrom
gewarren merged 28 commits intodotnet:mainfrom
Conversation
gewarren
reviewed
Jul 7, 2022
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
I left a few grammar improvements. Also, should the enumeration be added to profiling-enumerations.md?
docs/framework/unmanaged-api/profiling/cor-prf-handle-type-enumeration.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-getobjectidfromhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-interface.md
Outdated
Show resolved
Hide resolved
…meration.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…royhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…royhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…bjectidfromhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…bjectidfromhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…bjectidfromhandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
…rface.md Co-authored-by: Genevieve Warren <[email protected]>
Contributor
Author
I would have probably done less errors in french :^)
Good point. I'm udpating it. I also picked a format for the link to .NET 7 content based on .NET 5 one |
Contributor
The link is correct, but that include file doesn't exist, so you'll need to add it. |
gewarren
reviewed
Jul 8, 2022
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@gewarren: why did you close this PR? |
Contributor
|
Sorry, not sure what happened. |
Contributor
Author
I did the same thing by mistake on my own PR so don't be sorry ;^) |
Contributor
Author
I just added the missing file |
gewarren
approved these changes
Jul 18, 2022
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
gewarren
requested changes
Jul 18, 2022
docs/framework/unmanaged-api/profiling/cor-prf-handle-type-enumeration.md
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-createhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-destroyhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/icorprofilerinfo13-getobjectidfromhandle-method.md
Outdated
Show resolved
Hide resolved
docs/framework/unmanaged-api/profiling/profiling-enumerations.md
Outdated
Show resolved
Hide resolved
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
…tehandle-method.md Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
gewarren
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide the documentation for the new ICorProfilerInfo13 interface implemented by dotnet/runtime#71257
Describe your changes here.
Add the interface, methods and enumeration documentation
Fixes #Issue_Number (if available)