Add some AssemblyLoadContext documentation#1353
Conversation
|
This is a first pass at this documentation. It should be reasonably accurate.
|
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Great to see some details for AssemblyLoadContext
Fix AppDomain typo Add System.Runtime.Loader summary
swaroop-sridhar
left a comment
There was a problem hiding this comment.
Thanks for adding the documentation for ALC. I agree with your PR notes that we need more explanation and samples. I left some comments and suggestions. The changes looks good once they are addressed.
e3fce56 to
a3c42f7
Compare
|
I have addressed all feedback. The openpublishbuild completed without any new warnings. I am happy with the published results so far. @rpetrusha PTAL when you get a chance |
vitek-karas
left a comment
There was a problem hiding this comment.
LGTM in general - several nits and comments.
|
I have tried to address all the feedback. Waiting for the build to complete to take a look again. |
f039acf to
f799cc9
Compare
|
Build looks reasonable to me. This is the link https://review.docs.microsoft.com/en-us/dotnet/api/system.runtime.loader?view=netcore-2.2&branch=pr-en-us-1353 |
|
@sdmaclea, %2A means that the method name will be displayed without parameters, and that, if the method is overloaded, the link resolves to the top of the page (with the overload list) rather than to a specific overload. |
|
This looks good, @sdmaclea. I'll merge your PR now. Hopefully, it will be live tomorrow. |
|
@rpetrusha Thanks |
Summary
Add some AssemblyLoadContext documentation
Fix AppDomain typo
Add System.Runtime.Loader summary
Initial attempt to fix #1129
Fixes #785