Restored enumeration member remarks #2#1637
Merged
rpetrusha merged 2 commits intodotnet:masterfrom Jan 18, 2019
Merged
Conversation
rpetrusha
added
migration-fixes
Author
|
@tarekgh, could you review the changes to the CultureTypes enumeration, please? |
Member
|
CultureTypes enumeration changes LGTM. thanks |
mairaw
approved these changes
Jan 18, 2019
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
LGTM, left a few comments for you to consider @rpetrusha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restored enumeration member remarks #2
This PR restores enumeration member remarks for enumerations in the System.Globalization, System.IO.*, System.Reflection.*, System.Runtime, and System.Runtime.CompilerServices namespaces. The remarks are now ignored by the OPS build system. Depending on the remark, I've done either of two things:
Added the remark to the enumeration member's description (the <summary> section).
Added the remark to the enumeration type's remarks section.
Contributes to #1306