Conversation
.gitignore
Outdated
There was a problem hiding this comment.
this line is a duplicate; revert changes to this file
|
suggest adding |
|
⌚ |
|
@dougbu This is purely a transition PR to move classes from MVC into this Common repo.
Please just inspect the structure/project structure of what it entails to build this initial Common repo. If we want to add additional test coverage or add docs that can be done at a separate time, not going to snowball the purpose of this initial PR. |
|
I doubt the few missing docs and tests will ever be added. in any case, not all of my comments are about docs and tests. definitely need to recreate the *.kproj files for example. |
There was a problem hiding this comment.
class should be internal, or it will cause collissions.
|
⌚ |
|
Updated. Touched some existing files (not all). Added some tests to validate |
There was a problem hiding this comment.
what context is used in this test? main difference from Activate_InvokesValueAccessorWithExpectedValue() is check of activated value. suggest either adding an assertion to the above test or renaming this to Activate_SetsPropertyValue().
|
⌚ |
|
Updated. |
|
⌚ just for another confirmation on need to work around aspnet/dnx#1237 in src project.json files here |
|
hopes about including references to other shared projects dashed |
4 participants
NOTE: Ignore the utility classes and their corresponding tests. These were copied verbatim from Mvc and the only thing modified was their namespace.
NotNullAttributePropertyActivatorPropertyHelperCopyOnWriteDictionaryCopyOnWriteDictionaryandPropertyHelper.PropertyActivatordid not have any tests in Mvc.Working on a reaction PR to MVC.
For now users will have to manually include the shared source dependencies (ex:
CopyOnWriteDictionarywill require theNotNullAttributepackage) until aspnet/dnx#1237 is completed.