Cleanup conversion to Arcade by natemcmaster · Pull Request #1014 · dotnet/extensions

natemcmaster · 2019-01-29T23:26:23Z

Changes:

Revert bad merge on eng/Versions.props
Remove more obsolete code, mostly properties that were required for KoreBuild, but are now no longer in use
Update documentation to show new usage of build scripts
Add startvs.cmd
Replace IsProductComponent with IsShipping
Update artifact layout to match Arcade conventions
Rename RepositoryRoot to RepoRoot (arcade convention)
Update lang version to 7.3
Remove publish.proj and tools.proj (Arcade does this for us automatically)
Replace usages of IsTestProject with IsUnitTestProject (Arcade convention)
Fix warning as errors problem
Add ./eng/scripts/GenerateProjectList.ps1
Remove API check baseline.json files

natemcmaster · 2019-01-29T23:31:18Z

I recommend reviewing individual commits on this PR. Removing the baseline.json files along is like 30k changed lines. I put the massive changes into individual commits.

ryanbrandenburg

Looks great thanks for doing this, I didn't know that a fair portion of this was KoreBuild specific.

ryanbrandenburg · 2019-01-29T23:57:51Z

global.json

 {
  "sdk": {
-    "version": "3.0.100-preview-009750"
+    "version": "3.0.100-preview-010184"


We got one that met our criteria? Awesome.

At least for aspnet/Extensions, yes.

natemcmaster · 2019-01-30T00:35:07Z

/AzurePipelines run all

Follow-up to #1014. This props file should be unnecessary now.

* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde

* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel Commit migrated from dotnet/extensions@f41cfde

* Reorganize source code In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter. Commit migrated from dotnet/extensions@7ce647c * Merge branch 'release/2.1' into release/2.2 Commit migrated from dotnet/extensions@18fcffb * Merge branch 'release/2.2' Commit migrated from dotnet/extensions@34204b6 * Reorganize source code in preparation to move into aspnet/Extensions Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96 Commit migrated from dotnet/extensions@689c4a8 * Reorganize source code in preparation to move into aspnet/Extensions Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee Commit migrated from dotnet/extensions@04e957b * Reorganize source code in preparation to move into aspnet/Extensions Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185 Commit migrated from dotnet/extensions@9a4c61b * Reorganize source code in preparation to move into aspnet/Extensions Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d Commit migrated from dotnet/extensions@f3cd14a * Reorganize source code in preparation to move into aspnet/Extensions Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7 Commit migrated from dotnet/extensions@c38f9c1 * Use the SharedSourceRoot variable in project files Commit migrated from dotnet/extensions@888bcba * Allow caching of IEnumerable services (dotnet/extensions#575) Commit migrated from dotnet/extensions@c89a5b5 * Reduce event source logger allocations (dotnet/extensions#870) Commit migrated from dotnet/extensions@091ee13 * Use Arcade (dotnet/extensions#586) Use arcade Commit migrated from dotnet/extensions@f045899 * Cleanup conversion to Arcade (dotnet/extensions#1014) * Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel Commit migrated from dotnet/extensions@f41cfde * Shrink StringValues (dotnet/extensions#1283) Commit migrated from dotnet/extensions@2f8e1fb * Disable transitive project references in test projects (dotnet/extensions#1834) Commit migrated from dotnet/extensions@e7d5bea * Fix HTTP client benchmarks Commit migrated from dotnet/extensions@8f0f7fa * Add typed client creation benchmark Commit migrated from dotnet/extensions@20ce03a * Support netcoreapp3.1 TFM (dotnet/extensions#2336) * Support netcoreapp3.1 TFM * Unpin SDK for source build * Update to preview1 branding Commit migrated from dotnet/extensions@32cc816 * Normalize all file headers to the expected Apache 2.0 license Commit migrated from dotnet/extensions@cec6e75 * Switch file headers to the MIT license Commit migrated from dotnet/extensions@321a30c * Moves Microsoft.Extensions.* perf tests over * Using the Open key to fully sign assembly - Needed to later get InternalsVisibleTo on DI * Apply suggestions from code review Make batch commit using suggestions in PR feedback Co-authored-by: Adam Sitnik <[email protected]> * Fix compile + other feedback * Apply suggestions from code review Co-authored-by: Nate McMaster <[email protected]> Co-authored-by: Pavel Krymets <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Nate McMaster <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Co-authored-by: John Luo <[email protected]> Co-authored-by: Sam Harwell <[email protected]> Co-authored-by: Adam Sitnik <[email protected]>

* Remove obsolete targets, properties, and scripts * Replace IsProductComponent with IsShipping * Undo bad merge to version.props * Update documentation, and put workarounds into a common file * Replace usages of RepositoryRoot with RepoRoot * Remove API baselines * Remove unnecessary restore feeds and split workarounds into two files * Enable PR checks on all branches, and disable autocancel\n\nCommit migrated from dotnet/extensions@f41cfde

Nate McMaster added 6 commits January 29, 2019 14:34

Remove obsolete targets, properties, and scripts

8e71656

Replace IsProductComponent with IsShipping

5827477

Undo bad merge to version.props

7646d5c

Update documentation, and put workarounds into a common file

15745cc

Don't package Config.Test.Common

f0e2e25

Map RepositoryRoot => RepoRoot

7af39fd

natemcmaster requested a review from ryanbrandenburg January 29, 2019 23:26

natemcmaster requested review from Tratcher and pakrym as code owners January 29, 2019 23:26

Nate McMaster added 2 commits January 29, 2019 15:27

Remove API baselines

66d4244

Remove breakingchanges.json files

53cf45a

ryanbrandenburg approved these changes Jan 30, 2019

View reviewed changes

Remove unnecessary restore feeds and split workarounds into two files

43a18d8

natemcmaster closed this Jan 30, 2019

natemcmaster reopened this Jan 30, 2019

Nate McMaster added 5 commits January 29, 2019 16:50

Remove _GeneralBuildArg from build definition

8688b09

Enable PR checks on all branches, and disable autocancel

c531d9d

Try again

7dd542d

Add internal branches

b651a8f

Merge branch 'master' into cleanup

dd8e4a7

natemcmaster merged commit f41cfde into dotnet:master Jan 30, 2019

natemcmaster deleted the cleanup branch January 30, 2019 02:34

natemcmaster mentioned this pull request Jan 30, 2019

Remove unused .props file #1024

Merged

natemcmaster added a commit that referenced this pull request Jan 31, 2019

Remove unused .props file (#1024)

8535a13

Follow-up to #1014. This props file should be unnecessary now.

ghost locked as resolved and limited conversation to collaborators May 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup conversion to Arcade#1014

Cleanup conversion to Arcade#1014
natemcmaster merged 14 commits intodotnet:masterfrom
natemcmaster:cleanup

natemcmaster commented Jan 29, 2019 •

edited

Loading

Uh oh!

natemcmaster commented Jan 29, 2019

Uh oh!

ryanbrandenburg left a comment

Uh oh!

ryanbrandenburg Jan 29, 2019

Uh oh!

natemcmaster Jan 30, 2019

Uh oh!

natemcmaster commented Jan 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

natemcmaster commented Jan 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

natemcmaster commented Jan 29, 2019

Uh oh!

ryanbrandenburg left a comment

Choose a reason for hiding this comment

Uh oh!

ryanbrandenburg Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

natemcmaster Jan 30, 2019

Choose a reason for hiding this comment

Uh oh!

natemcmaster commented Jan 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

natemcmaster commented Jan 29, 2019 •

edited

Loading