Conversation
There was a problem hiding this comment.
Run \\GarnetA\Share\KProjUpdateScript\UpdateKProjectFiles.ps1 on this (can just run it in global.json directory)
There was a problem hiding this comment.
Ah! This gets me every time
|
If you can add some really simple tests for these two classes real quickly so we have coverage for all of our common utilities. Can follow same format as the other test files. Will need to add a reference to |
|
⌚ |
|
|
There was a problem hiding this comment.
why is this a public field instead of a property?
|
⌚ minor comments mostly but would like to see a follow-up commit |
|
We are actually not doing this anymore, its moving to the Testing repo. I will look at the comments though |
|
ah, thought PR was closed because it went in |
|
It did, we reverted it. |
@Eilon @NTaylorMullen