Skip to content

Make Mono.WebAssembly.Interop non-shipping#2994

Merged
wtgodbe merged 2 commits intorelease/3.1from
pranavkm-patch-1
Feb 19, 2020
Merged

Make Mono.WebAssembly.Interop non-shipping#2994
wtgodbe merged 2 commits intorelease/3.1from
pranavkm-patch-1

Conversation

@pranavkm
Copy link

No description provided.

@wtgodbe
Copy link
Member

wtgodbe commented Feb 19, 2020

Good for 3.1.3

@wtgodbe
Copy link
Member

wtgodbe commented Feb 19, 2020

D:\a\1\s\eng\targets\ResolveReferences.targets(226,5): error : Project shouldn't have reference assembly but folder exists D:\a\1\s\src\JSInterop\Mono.WebAssembly.Interop\src/../ref/ [D:\a\1\s\src\JSInterop\Mono.WebAssembly.Interop\src\Mono.WebAssembly.Interop.csproj]

@dougbu do we need to remove the ref assembly from this project now that it's non-shipping?

@dougbu
Copy link

dougbu commented Feb 19, 2020

do we need to remove the ref assembly from this project now that it's non-shipping?

Only shared framework assemblies should have ref/ assemblies. We're enforcing that in dotnet/aspnetcore but don't have the same in place in this repo. But, as long as the ref/ assembly doesn't make it into Microsoft.Internal.Extensions.Ref, having a ref/ project here is only wasteful.

@dougbu
Copy link

dougbu commented Feb 19, 2020

Ooops, I didn't read the error closely enough. Guess we have the error in this repo too. Need to remove the ref/ project.

@pranavkm pranavkm added this to the 3.1.3 milestone Feb 19, 2020
@pranavkm
Copy link
Author

Spoke to @wtgodbe offline. In 3.2, we moved this package to the AspNetCore repo and it might be consolidated with another package after we're done with API reviews. Removing it from 3.1 seems reasonable.

@wtgodbe
Copy link
Member

wtgodbe commented Feb 19, 2020

LGTM. @dougbu @JunTaoLuo any concerns?

@wtgodbe wtgodbe merged commit 96e04fc into release/3.1 Feb 19, 2020
@wtgodbe wtgodbe deleted the pranavkm-patch-1 branch February 19, 2020 19:18
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants