Introducing BufferEntryCollection which is used by MVC and Razor for buffering output data.#3
Conversation
…buffering output data.
|
|
once you've verified as a package (talked in person).
Common.sln
Outdated
There was a problem hiding this comment.
nit: revert this particular change. keep the version moving upwards.
|
⌚ |
|
Updated.. |
There was a problem hiding this comment.
To my knowledge, we put public class in Internal namespace so that the class can be consumed but we don't guarantee the API's stable. Now that an internal class is placed here doesn't it defeat the purpose of Internal namespace?
Or do we can different guidelines for how to use Internal namespace?
There was a problem hiding this comment.
@troydai the shared-source projects are a special case. everything is internal because otherwise any assembly that depends on (for example) both Razor and MVC would see two versions of the classes. and the classes in this repo are in the namespace we chose for it.
There was a problem hiding this comment.
Make sense. Thanks for the clarification. I do think the namespace can be more specific though.
|
|
|
Updated @troydai please have a look.. |
|
See my latest comment. Still ⌚ |
|
|
4 participants
aspnet/Razor#296