Conversation
pakrym
force-pushed
the
pakrym/add-common-configs
branch
from
1f483be to
eb84751
Compare
pranavkm
approved these changes
Dec 22, 2017
| private static TextWriter _standardOutput; | ||
| private static StringBuilder _standardOutputText; | ||
|
|
||
| static partial void BeforeMain(string[] args); |
|
|
||
| namespace BenchmarkDotNet.Attributes | ||
| { | ||
| public class CoreConfig : ManualConfig |
| namespace BenchmarkDotNet.Attributes | ||
| { | ||
| [AttributeUsage(AttributeTargets.Class | AttributeTargets.Assembly)] | ||
| public class AspNetCoreBenchmarkAttribute : Attribute, IConfigSource |
| { | ||
| public static bool UseValidationConfig { get; set; } | ||
|
|
||
| public Type ConfigType { get;set; } |
pranavkm
reviewed
Dec 22, 2017
| namespace BenchmarkDotNet.Attributes | ||
| { | ||
| public class CoreConfig : ManualConfig | ||
| public class DefaultCoreConfig : ManualConfig |
pakrym
force-pushed
the
pakrym/add-common-configs
branch
from
92a4744 to
72598ce
Compare
natemcmaster
pushed a commit
that referenced
this pull request
Nov 7, 2018
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We copy paste the same thing into all the repos, just carry it with
Microsoft.AspNetCore.BenchmarkRunner.Sources.Validation config does not include
JitOptimizationsValidator.FailOnErrorso it won't fail in debug anymore.Also adds support for
BeforeMainpartial method that is useful for debugging sometimes.