Merged
Conversation
* Update dependencies to 2.2.0 rtm * Update branding to 2.2.1 * Update package baselines to 2.2.0 * Add a restore source for 2.2.0 RTM
muratg
reviewed
Nov 14, 2018
| <PropertyGroup Label="RestoreSources"> | ||
| <RestoreSources>$(DotNetRestoreSources)</RestoreSources> | ||
|
|
||
| <!-- This feed contains the 2.2.0 RTM runtime. This can be removed after it is released to nuget.org. --> |
There was a problem hiding this comment.
Should we add a post-release activity to clean up things like this?
Member
There was a problem hiding this comment.
I don't think this is necessary. The dotnet-core blob and myget feeds contain the 2.2.0 packages
Author
There was a problem hiding this comment.
Yeah, I'll open a bug on aspnetcore-internal to track this.
Author
There was a problem hiding this comment.
The dotnet-core blob and myget feeds contain the 2.2.0 packages
Cool, i'll remove this feed now. Didn't see this comment before I merged.
muratg
reviewed
Nov 14, 2018
| { | ||
| var url = $"{source}/{id}/{version}"; | ||
| var url = _feedv3.HasValue() | ||
| ? $"{source}/{id.ToLowerInvariant()}/{version}/{id.ToLowerInvariant()}.{version}.nupkg" |
There was a problem hiding this comment.
:/ I'm sure this will bite us elsewhere too. (nuget casing issues)
muratg
approved these changes
Nov 14, 2018
natemcmaster
pushed a commit
that referenced
this pull request
Nov 21, 2018
* Added execution time duration into HealthReportEntry and TotalDuration on HealthReport * review PR feedback from @rynowak. * added the same duration into HealthReportEntry and log when the health check throw
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
FYI @mmitche