Added tests that can be implemented for any provider to ensure consistency#600
Merged
ajcvickers merged 1 commit intomasterfrom Dec 7, 2018
Merged
Added tests that can be implemented for any provider to ensure consistency#600ajcvickers merged 1 commit intomasterfrom
ajcvickers merged 1 commit intomasterfrom
Conversation
…tency Partly to allow me to get a better understanding of the code, partly so we can have a better idea that all the providers work in a consistent manner. Part of aspnet/Configuration#559 I will file issues for things found.
ajcvickers
force-pushed
the
FromWhereDontCare1130
branch
from
372ca04 to
8dcd5b0
Compare
HaoK
reviewed
Dec 7, 2018
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(StandardTestTfms)</TargetFrameworks> | ||
| <TargetFrameworks>$(StandardTestTfms);net461</TargetFrameworks> |
Member
There was a problem hiding this comment.
Just making sure this net461 is intentional
Author
There was a problem hiding this comment.
Yes, because the AzureKeyVault tests target it, and they now depend on this for the base infrastructure.
HaoK
approved these changes
Dec 7, 2018
Member
HaoK
left a comment
HaoK
left a comment
There was a problem hiding this comment.
I didn't take a deep look at the actual test behaviors, I think more tests is always good, we'll probably discuss this again when I do the json switch + refactor the file load logic which will impact these tests (hopefully clean this up and make it look not quite so scary :))
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly to allow me to get a better understanding of the code, partly so we can have a better idea that all the providers work in a consistent manner.
Part of aspnet/Configuration#559
I will file issues for things found.