Fix package references from M.E.AI packages#7076
Merged
stephentoub merged 2 commits intodotnet:mainfrom Nov 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes package references in Microsoft.Extensions.AI packages by conditionally including certain framework-provided packages only for target frameworks older than .NET 10.0. The changes ensure that packages like System.Text.Json, System.Diagnostics.DiagnosticSource, and System.Threading.Channels are only referenced when targeting frameworks that don't include them in the base framework.
Key changes:
- Adds conditional package references for .NET 10.0 compatibility across AI libraries
- Removes System.Memory.Data package references from OpenAI and AzureAIInference projects
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft.Extensions.AI.csproj | Adds condition to exclude System.Diagnostics.DiagnosticSource, System.Text.Json, and System.Threading.Channels for net10.0+ |
| Microsoft.Extensions.AI.OpenAI.csproj | Removes System.Memory.Data reference and conditionally excludes System.Text.Json for net10.0+ |
| Microsoft.Extensions.AI.AzureAIInference.csproj | Removes System.Memory.Data reference and conditionally excludes System.Text.Json for net10.0+ |
| Microsoft.Extensions.AI.Abstractions.csproj | Adds condition to exclude System.Text.Json for net10.0+ |
eiriktsarpalis
approved these changes
Nov 24, 2025
Member
Author
|
I think the failure here will be addressed by #7078 |
This was referenced Dec 11, 2025
This was referenced Jan 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow