Promote FakeLogCollector.GetLogsAsync(CancellationToken) from experimental to stable#7332
Merged
Demo30 merged 6 commits intodotnet:mainfrom Feb 24, 2026
Conversation
added 4 commits
March 31, 2025 14:44
added 2 commits
February 24, 2026 09:50
…akelogcollector-waitforlogs-remove-experimental
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes the FakeLogCollector.GetLogsAsync(CancellationToken) method from experimental to stable status in the Microsoft.Extensions.Diagnostics.Testing library. The change allows developers to use this async enumeration API in production code without experimental warnings.
Changes:
- Updated API baseline JSON file to mark
GetLogsAsyncas "Stable" instead of "Experimental" - Removed the
[Experimental]attribute from theGetLogsAsyncmethod - Cleaned up unused using statements (
System.Diagnostics.CodeAnalysisandMicrosoft.Shared.DiagnosticIds)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.Diagnostics.Testing/Microsoft.Extensions.Diagnostics.Testing.json | Updated the API stage from "Experimental" to "Stable" for GetLogsAsync method in the API baseline |
| src/Libraries/Microsoft.Extensions.Diagnostics.Testing/Logging/FakeLogCollector.LogEnumeration.cs | Removed the [Experimental] attribute and unused using statements from the GetLogsAsync method implementation |
evgenyfedorov2
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow