Fix buffer copying for HybridCachePayload.#7343
Merged
cincuranet merged 2 commits intomainfrom Feb 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in HybridCache's payload parsing logic that caused an ArgumentException when retrieving cached entries with multiple tags. The issue occurred when parsing cached data with 2+ tags while passing empty knownTags, causing all tags to be moved into a pending tags buffer. The code incorrectly used Array.CopyTo() to copy from an oversized ArrayPool-rented buffer to an exact-sized destination array, attempting to copy more elements than the destination could hold.
Changes:
- Fixed buffer copying in
HybridCachePayload.TryParseto useArray.Copywith explicit count instead ofCopyTo - Added comprehensive test coverage for the scenario with 2 and 3 pending tags
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.Caching.Hybrid/Internal/HybridCachePayload.cs | Changed line 312 from pendingTagBuffer.CopyTo(final, 0) to Array.Copy(pendingTagBuffer, final, pendingTagsCount) to copy only the used portion of the rented buffer |
| test/Libraries/Microsoft.Extensions.Caching.Hybrid.Tests/PayloadTests.cs | Added RoundTrip_WithPendingTags_WhenKnownTagsMismatch theory test with 2 and 3 tag scenarios to verify the fix |
MihaZupan
reviewed
Feb 26, 2026
src/Libraries/Microsoft.Extensions.Caching.Hybrid/Internal/HybridCachePayload.cs
Outdated
Show resolved
Hide resolved
MihaZupan
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7342.
Microsoft Reviewers: Open in CodeFlow