Merged
Conversation
- Fix duplicate test case IDs caused by unused gapBeginningEnd loop variable - Suppress non-serializable data warnings with DisableDiscoveryEnumeration Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces noisy xUnit test-log warnings in the AI Abstractions test suite by ensuring theory data is unique and by preventing xUnit from enumerating non-serializable MemberData during test discovery.
Changes:
- Fixes duplicate theory-case IDs by correctly passing the
gapBeginningEndloop variable into generatedMemberData. - Adds
DisableDiscoveryEnumeration = truetoMemberDataattributes that use non-serializable theory data, suppressing discovery-time warnings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Utilities/AIJsonUtilitiesTests.cs | Disables discovery enumeration for MemberData based schema stress tests to avoid non-serializable data warnings. |
| test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/SpeechToText/SpeechToTextResponseUpdateExtensionsTests.cs | Fixes theory data generation to include gapBeginningEnd, preventing duplicate test case IDs. |
| test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/ToolApprovalResponseContentTests.cs | Disables discovery enumeration for ToolCallContent MemberData to suppress non-serializable discovery warnings. |
| test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/Contents/ToolApprovalRequestContentTests.cs | Disables discovery enumeration for ToolCallContent MemberData to suppress non-serializable discovery warnings. |
| test/Libraries/Microsoft.Extensions.AI.Abstractions.Tests/ChatCompletion/ChatResponseUpdateExtensionsTests.cs | Fixes theory data generation to include gapBeginningEnd, preventing duplicate test case IDs. |
stephentoub
approved these changes
Mar 7, 2026
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Mar 17, 2026
- Fix duplicate test case IDs caused by unused gapBeginningEnd loop variable - Suppress non-serializable data warnings with DisableDiscoveryEnumeration Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flood the test log.
Microsoft Reviewers: Open in CodeFlow