Conversation
|
Ping @Tratcher |
|
Write a test here or in HttpAbstractions. |
|
Write a test here. |
|
Added a test |
|
|
eb66f60 to
9eac23c
Compare
|
This code is used by many other places. Is this behavior the right thing in all cases (I think not). Can you make a list of the callers and see if there are unintended side effects? |
|
Most uses of the ActivatorUtilities function is using the overload that doesn't take a param [] of args so they are unaffected by this change. SignalR-Server uses it a couple times mostly in tests, Mvc uses it once and passes a string Also, DependencyInjection has it's own implementation of this class (looks like just copy pasta from some time ago) |
|
Ping @davidfowl |
|
we shouldn't allow nulls by default. It should be indicated with a default value like: public class Foo
{
public Foo(Something x = null, SomethingNotNull y)
{
}
}/cc @pranavkm Don't we support something like this? |
|
Yes, default values should work. However @davidfowl, your example wouldn't actually compile. |
|
Any update on this PR? I'm not entirely sure I like this behavior. The |
Fix #68 - use trace for header logging
@Tratcher
aspnet/HttpAbstractions#331