Skip to content

Remove special logic for TypeConverterAttribute#2659

Merged
jtschuster merged 9 commits intodotnet:mainfrom
jtschuster:typeConverter
Mar 1, 2022
Merged

Remove special logic for TypeConverterAttribute#2659
jtschuster merged 9 commits intodotnet:mainfrom
jtschuster:typeConverter

Conversation

@jtschuster
Copy link
Member

@jtschuster jtschuster commented Feb 25, 2022

Fixes #1942

We no longer need special logic for TypeConverterAttributes. This removes that code, and adds a test to reproduce the issue found in #1942.

vitek-karas
vitek-karas approved these changes Feb 25, 2022
View reviewed changes
@jtschuster jtschuster merged commit b10e1bc into dotnet:main Mar 1, 2022
@marek-safar
Copy link
Contributor

marek-safar commented Mar 2, 2022

Are the annotations correct in .NET6 release so targeting LTS from net7 works as expected?

@eerhardt
Copy link
Member

eerhardt commented Mar 3, 2022 •
edited
Loading

Are the annotations correct in .NET6 release so targeting LTS from net7 works as expected?

Yes. See dotnet/runtime#39144. TypeConverterAttribute was made trim-compatible in .NET 5.

@agocke @vitek-karas @jtschuster - Is there any chance this change can be backported to .NET 6 for Maui? I'm seeing the following warnings 330 times when trimming a Maui app, which is causing A LOT of noise.

ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]
ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]
ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]
ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]
ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]
ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]
ILLink : Trim analysis warning IL2111: Microsoft.Maui.Controls.VisualElement.Visual: Method 'Microsoft.Maui.Controls.VisualTypeConverter.CreateVisual(Type)' with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method. [C:\git\WeatherTwentyOne\src\WeatherTwentyOne\WeatherTwentyOne.csproj]

In case you are curious, I explained the reason these warnings occur here.

@agocke
Copy link
Member

agocke commented Mar 3, 2022

Given that this is an SDK-only change with high impact, I think it has a chance.

agocke pushed a commit to agocke/linker that referenced this pull request Mar 18, 2022
@jtschuster @agocke
Remove special logic for TypeConverterAttribute (dotnet#2659)
2140951 
(cherry picked from commit b10e1bc)
agocke added a commit that referenced this pull request Mar 23, 2022
@agocke @jtschuster
Remove special logic for TypeConverterAttribute (#2659) (#2695)
eab62f9 
(cherry picked from commit b10e1bc)

Co-authored-by: Jackson Schuster <[email protected]>
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
@jtschuster
Remove special logic for TypeConverterAttribute (dotnet/linker#2659)
f9f184f 
Commit migrated from dotnet/linker@b10e1bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove special handling of TypeDescriptionProviderAttribute and TypeConverterAttribute

5 participants

@jtschuster @marek-safar @eerhardt @agocke @vitek-karas