Don't dispose of linked assembly in VerifyLinkingOfOtherAssemblies#2672
Merged
marek-safar merged 1 commit intodotnet:mainfrom Mar 2, 2022
Merged
Conversation
Disposing of the assembly leads to code after it to throw if it triggers a deferred read of something in the assembly. This wasn't causing any issues in the illinker test framework. I'm making changes in Unity and I ran into this. There is no need to dispose of the assembly at this point. The resolver will be diposed and will handle disposing of the assembly.
vitek-karas
approved these changes
Mar 2, 2022
mrvoorhe
added a commit
to Unity-Technologies/linker
that referenced
this pull request
Mar 3, 2022
mrvoorhe
added a commit
to Unity-Technologies/linker
that referenced
this pull request
Jun 14, 2022
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disposing of the assembly leads to code after it to throw if it triggers a deferred read of something in the assembly. This wasn't causing any issues in the illinker test framework. I'm making changes in Unity and I ran into this.
There is no need to dispose of the assembly at this point. The resolver will be diposed and will handle disposing of the assembly.