Merged
Conversation
sbomer
approved these changes
Mar 11, 2022
| yield return new SystemTypeValue (new TypeProxy (nestedType)); | ||
| } | ||
|
|
||
| private partial bool TryGetBaseType (TypeProxy type, out TypeProxy baseType) |
Member
There was a problem hiding this comment.
I'm not sure what's best practice for value types, but I wonder if it's worth making the out param [NotNullWhen(true)] out TypeProxy? so that we get analysis warnings if someone tries to access the value if it returns false?
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Commit migrated from dotnet/linker@98c81d5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.