[release/6.0.2xx] Remove special logic for TypeConverterAttribute (#2659)#2695
Merged
agocke merged 1 commit intodotnet:release/6.0.2xxfrom Mar 23, 2022
Merged
[release/6.0.2xx] Remove special logic for TypeConverterAttribute (#2659)#2695agocke merged 1 commit intodotnet:release/6.0.2xxfrom
agocke merged 1 commit intodotnet:release/6.0.2xxfrom
Conversation
(cherry picked from commit b10e1bc)
jeffschwMSFT
approved these changes
Mar 18, 2022
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We should take for consideration in 6.0.2xx.
jtschuster
approved these changes
Mar 21, 2022
agocke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit b10e1bc)
Summary
The linker has had a special case for the TypeConverterAttribute for a while. In .NET 6, the logic was properly annotated, and the special casing can actually produce spurious warnings. This change removes the special casing.
Impact
Consumers like MAUI use TypeConverterAttribute and are seeing lots of spurious warnings, which is harming their ability to make things trimmable for .NET 6.
Risk
Low. Removes special casing.