Skip to content

Avoid running GetDisplayNameTests in parallel#2701

Merged
tlakollo merged 1 commit intomainfrom
DisableParallelExecutionOnTest
Mar 21, 2022
Merged

Avoid running GetDisplayNameTests in parallel#2701
tlakollo merged 1 commit intomainfrom
DisableParallelExecutionOnTest

Conversation

@tlakollo
Copy link
Contributor

@tlakollo tlakollo commented Mar 21, 2022

There seems to be a race condition on Cecil while trying to get GenericParameters, if a multithreaded test asks simultaneously about GenericParameters on the same type Cecil answers could vary creating test failures.
Fixes #2693

@tlakollo
Avoid running GetDisplayNameTests in parallel
2ed092f 
There seems to be a race condition on Cecil while trying to get GenericParameters, if a multithreaded test asks simultaneously about GenericParameters on the same type Cecil answers could vary creating test failures. 
Fixes #2693
@tlakollo tlakollo requested a review from marek-safar as a code owner March 21, 2022 23:23
@tlakollo tlakollo self-assigned this Mar 21, 2022
sbomer
sbomer approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tlakollo tlakollo merged commit 5d8277a into main Mar 21, 2022
@tlakollo tlakollo deleted the DisableParallelExecutionOnTest branch March 21, 2022 23:54
@marek-safar
Copy link
Contributor

marek-safar commented Mar 22, 2022

Do you know which Cecil piece is causing this?

@tlakollo
Copy link
Contributor Author

tlakollo commented Mar 22, 2022

Given that the problematic code in linker is https://github.com/dotnet/linker/blob/main/src/linker/Linker/TypeReferenceExtensions.cs#L43-L58
We could assume that is likely caused because the count of genericParametersCount or declaringTypeGenericParametersCount was incorrect. Causing the code to go to the else statement and print the incorrect type.
That would make https://github.com/mono/cecil/blob/main/Mono.Cecil/IGenericParameterProvider.cs#L46-L56 in Cecil the possible cause. Given that is likely that the problem will go away while debugging the bug would need to be found only by code inspection. Spending a few min looking at the code there, it seems to be like it should run fine, so it might be something subtle.

@sbomer sbomer mentioned this pull request Apr 15, 2022
Closed
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
@tlakollo
Avoid running GetDisplayNameTests in parallel (dotnet/linker#2701)
301d7bf 
There seems to be a race condition on Cecil while trying to get GenericParameters, if a multithreaded test asks simultaneously about GenericParameters on the same type Cecil answers could vary creating test failures. 
Fixes dotnet/linker#2693

Commit migrated from dotnet/linker@5d8277a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbomer sbomer sbomer approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@tlakollo tlakollo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestGetDisplayName is flaky

3 participants

@tlakollo @marek-safar @sbomer