-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Description
I plan to fix these:
Microsoft.NETCore.App.versions.txt no longer has Core-Setup hash, and is missing CoreCLR (in the runtime package txt files).
Commit hash no longer appears in pkgproj nupkg descriptions. (The managed projects now have a repository element containing this information, but pkgproj-based projects don't.)
Microsoft.NETCore.App.Internal (legacy netcoreapp framework package) has some differences in build/netcoreapp3.0/:
- It doesn't include
Microsoft.NETCore.App.Internal.propsor the platform manifest. With a trivial fix to put these in the nupkg, I see these further diffs: PackageConflictPreferredPackagesproperty is now empty (just a;)._Microsoft_NETCore_App_Internal_Versionis renamed_Microsoft_NETCore_App_VersionPackageConflictPlatformManifestspoints tonetcoreapp.PlatformManifest.txt(the original name of the file, not the name it has in the package).- These are legacy packages used for consumption in tests. This difference doesn't affect Core-Setup's tests. I'm on the fence about fixing it (vs leaving the files out entirely) but I want to reduce the migration risk on CoreCLR and ASP.NET Core.
Shared frameworks:
- WindowsDesktop shared framework has some files with Microsoft.NETCore.App naming that should be Microsoft.WindowsDesktop.App.
- Both shared frameworks include a reference to
Microsoft.DotNet.Build.Tasks.Packagingin their deps json files. .versionfile has no commit hash.
I don't plan to fix these before merging the migration:
Platform manifests have symbol files in them now, in general.
- I believe this is just a little useless data that should be trimmed for size, but has no effect.
Reactions are currently unavailable