-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-Infrastructure-coreclruntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner
Description
A change to src/libraries/pkg/Microsoft.NETCore.Platforms/runtime.json requires a full update cycle, which includes:
- a PR updating
runtime.jsonmerged in runtime repo - SDK repo picks up runtime change
- runtime picks up the updated SDK
This blocks building CLR tests on a new platform, until all of the above has happened (or we patch SDK after the restore). For example, my current workaround is:
# workaround: overwrite file containing updated RIDs from libraries
/runtime $ cp src/libraries/pkg/Microsoft.NETCore.Platforms/runtime.json \
.dotnet/sdk/5.0.100-preview.6.20310.4/RuntimeIdentifierGraph.json
# then cross-compile CLR tests without getting restore errors
/runtime $ ROOTFS_DIR=$(pwd)/.tools/rootfs/x64 ./src/coreclr/build-test.sh \
-x64 -cross -os illumos -gccIn the age of live-live builds, is it possible to ensure LiveRuntimeIdentifierGraphPath from eng/liveBuilds.targets is properly picked up during the SDK resolution for test build? Currently it seem to have no effect (despite being imported in src/coreclr/tests/src/Common/test_dependencies/test_dependencies.csproj) and SDK ends up using .dotnet/sdk/<version>/RuntimeIdentifierGraph.json, instead of the runtime.json file pointed by LiveRuntimeIdentifierGraphPath.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-Infrastructure-coreclruntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner