-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Description
While working on moving pred list building earlier I am seeing spurious diffs from optInvertLoops.
Looks like it expects blocks to have been renumbered but it doesn't check or try and renumber. Morph (which is a bit upstream) will often renumber so this only impacts a small set of methods.
runtime/src/coreclr/jit/optimizer.cpp
Lines 5145 to 5152 in e6bb676
| for (BasicBlock* const predBlock : bTest->PredBlocks()) | |
| { | |
| unsigned bNum = predBlock->bbNum; | |
| if ((loopFirstNum <= bNum) && (bNum <= loopBottomNum)) | |
| { | |
| // Looks like the predecessor is from within the potential loop; skip it. | |
| continue; | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMICLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI