Reuse more templates in our build#101197
Merged
jkoritzinsky merged 15 commits intodotnet:mainfrom Apr 19, 2024
Merged
Conversation
…jobs as strongly-typed template parameters don't allow unknown parameters and I don't want to declare a ton of optional ones we aren't going to ever use.
… (to get it in the right place in the pipeline)
Member
Author
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
|
Seems like all failures are unrelated. Would we benefit from also running the outerloop pipeline? |
This was referenced Apr 17, 2024
Member
Author
|
This change only affects the runtime and runtime-official pipelines, so there's no need to run any outerloop pipelines. |
akoeplinger
approved these changes
Apr 18, 2024
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
One comment/change, LGTM otherwise
Co-authored-by: Alexander Köplinger <[email protected]>
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Co-authored-by: Alexander Köplinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the generate-offsets and workloads jobs based on the global-build-job template.
Make the publish-signed-artifacts job based on the Arcade template and use more 1ES pipeline features (as it's internal only and doesn't need to run in a non-1ES context).