Merged
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
am11
reviewed
Apr 26, 2024
Co-authored-by: Adeel Mujahid <[email protected]>
This was referenced Apr 27, 2024
Member
Author
|
Looks like the x86 build has a failure with the new compiler. Reverting that for now. We'll need to deal with that in a separate focused PR. Other architectures appear to be fine. /__w/1/s/src/coreclr/pal/inc/pal.h:3605:5: error: __sync builtin operation MUST have natural alignment (consider using __atomic). [-Werror,-Wsync-alignment]
3605 | __sync_val_compare_and_swap(
| ^
/__w/1/s/src/coreclr/pal/inc/pal.h:3471:5: error: __sync builtin operation MUST have natural alignment (consider using __atomic). [-Werror,-Wsync-alignment]
3471 | __sync_add_and_fetch(lpAddend, (LONGLONG)1)
| ^
/__w/1/s/src/coreclr/pal/inc/pal.h:3506:5: error: __sync builtin operation MUST have natural alignment (consider using __atomic). [-Werror,-Wsync-alignment]
3506 | __sync_sub_and_fetch(lpAddend, (LONGLONG)1)
| ^
3 errors generated. |
Member
Author
|
@lewing do you think the wasm failures are related to this change? |
Member
|
The wasm failures are know issues. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Update build to `net9.0` images * Update docs/workflow/building/coreclr/linux-instructions.md Co-authored-by: Adeel Mujahid <[email protected]> * Revert x86 build change --------- Co-authored-by: Sven Boemer <[email protected]> Co-authored-by: Adeel Mujahid <[email protected]>
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
* Update build to `net9.0` images * Update docs/workflow/building/coreclr/linux-instructions.md Co-authored-by: Adeel Mujahid <[email protected]> * Revert x86 build change --------- Co-authored-by: Sven Boemer <[email protected]> Co-authored-by: Adeel Mujahid <[email protected]>
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Update build to `net9.0` images * Update docs/workflow/building/coreclr/linux-instructions.md Co-authored-by: Adeel Mujahid <[email protected]> * Revert x86 build change --------- Co-authored-by: Sven Boemer <[email protected]> Co-authored-by: Adeel Mujahid <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will update the branch to building with LLVM 18.1.4. Everything else should be the same relative to the
net8.0image flavor (which we intend to apply torelease/8.0branch in July or so).Supports: #91826
dotnet/dotnet-buildtools-prereqs-docker#1015
@sbomer