unblock Unix Domain Socket on Dispose on macOS#101753
Merged
wfurt merged 9 commits intodotnet:mainfrom May 22, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
May 1, 2024
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Unix.cs
Outdated
Show resolved
Hide resolved
This was referenced May 1, 2024
Member
Author
|
Note that the linked issue can also be fixed by adding |
tmds
reviewed
May 1, 2024
tmds
reviewed
May 1, 2024
|
|
||
| try | ||
| { | ||
| client.Receive(buffer); |
Member
There was a problem hiding this comment.
If there's a regression that causes TryUnblockSocket to break, the test will hang at client.Receive and never time out.
Member
There was a problem hiding this comment.
We can do some things like:
Member
Author
There was a problem hiding this comment.
I was thinking about it. However, I think we would notice it and fix it. XUnit now spits out warnings about long running tasks.
tmds
approved these changes
May 3, 2024
danmoseley
reviewed
May 3, 2024
src/libraries/System.Net.Sockets/tests/FunctionalTests/UnixDomainSocketTest.cs
Show resolved
Hide resolved
MihaZupan
approved these changes
May 21, 2024
antonfirsov
approved these changes
May 22, 2024
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
* unblock Unix Domain Socket on dispose on macOS * feedback * feedback * windows * feedback
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* unblock Unix Domain Socket on dispose on macOS * feedback * feedback * windows * feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #101539
When.
Interop.Sys.Disconnectis called on macOS with UDS, it fails and we end up in endlessTryUnblockSocketloop.We could fallback to
Shutdownon any error - this is just smallest change to fix the reported issue.,Lot of the abortive jargon around here really make sense only for TCP imho and I'm n to sure how applicable the logic is to other socket types.