Conversation
jkotas
commented
May 1, 2024
jkotas
commented
- Remove unnecessary System.Type wrapper for type name parsing in tools. Create the type directly from the parsed name.
- Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions with S.R.M.TypeNameParser
- Move type name Unescape and Split helpers into dedicated helper type
- Other cleanup
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
- Remove unnecessary System.Type wrapper for type name parsing in tools. Create the type directly from the parsed name. - Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions with S.R.M.TypeNameParser - Move type name Unescape and Split helpers into dedicated helper type - Other cleanup
|
@MichalStrehovsky Could you please review this PR when you get a chance? The type name parsing in the managed type system is the most substantial change. It sets up the ground for replacing |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There are test build failures, but otherwise looks reasonable to me, thanks for setting this towards a AssemblyNameInfo path! |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Remove unnecessary System.Type wrapper for type name parsing in tools. Create the type directly from the parsed name. - Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions with S.R.M.TypeNameParser - Move type name Unescape and Split helpers into dedicated helper type - Other cleanup
- Remove unnecessary System.Type wrapper for type name parsing in tools. Create the type directly from the parsed name. - Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions with S.R.M.TypeNameParser - Move type name Unescape and Split helpers into dedicated helper type - Other cleanup
4 participants
