[CI][aot] Do not overwrite `scenarios` argument if they were passed by ilonatommy · Pull Request #103229 · dotnet/runtime

ilonatommy · 2024-06-10T15:15:03Z

Continuation of switching off HybridGlobalization tests on v8. HybridGlobalization_AOT lane on CI was still running V8 because it was overwriting the scenarios argument passed here:

runtime/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

Line 216 in e6c2e53

scenarios:

Example of run with v8 on:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=702059&view=logs&j=2c5d15bf-ca52-57a8-9a4e-bb898fb954b8

Now we don't overwrite if scenarios is already defined.

ilonatommy · 2024-06-10T15:15:13Z

/azp run runtime-wasm

azure-pipelines · 2024-06-10T15:15:24Z

Azure Pipelines failed to run 1 pipeline(s).

dotnet-policy-service · 2024-06-10T15:15:32Z

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

eng/pipelines/common/templates/wasm-library-aot-tests.yml

ilonatommy · 2024-06-10T15:41:47Z

/azp run runtime-wasm

azure-pipelines · 2024-06-10T15:42:03Z

Azure Pipelines failed to run 1 pipeline(s).

ilonatommy · 2024-06-11T08:18:11Z

/azp run runtime-wasm

azure-pipelines · 2024-06-11T08:18:25Z

Azure Pipelines failed to run 1 pipeline(s).

ilonatommy · 2024-06-11T08:26:23Z

/azp run runtime-wasm

azure-pipelines · 2024-06-11T08:26:31Z

Azure Pipelines failed to run 1 pipeline(s).

ilonatommy · 2024-06-11T09:37:47Z

/azp run runtime-wasm

azure-pipelines · 2024-06-11T09:37:55Z

Azure Pipelines failed to run 1 pipeline(s).

ilonatommy · 2024-06-11T09:38:50Z

@akoeplinger, most probably I have an indent/syntax problem that I cannot spot, could you please take a look?

akoeplinger · 2024-06-11T09:52:43Z

@ilonatommy it looks like some issue with the empty parameter: https://dev.azure.com/dnceng-public/public/_build/results?buildId=703502&view=results

ilonatommy · 2024-06-11T10:01:32Z

/azp run runtime-wasm

azure-pipelines · 2024-06-11T10:01:40Z

Azure Pipelines failed to run 1 pipeline(s).

ilonatommy · 2024-06-11T10:04:58Z

@ilonatommy it looks like some issue with the empty parameter: https://dev.azure.com/dnceng-public/public/_build/results?buildId=703502&view=results

Thank you, I did not look there 🤦

ilonatommy · 2024-06-11T10:05:26Z

/azp run runtime-wasm

azure-pipelines · 2024-06-11T10:05:37Z

Azure Pipelines successfully started running 1 pipeline(s).

eng/pipelines/common/templates/wasm-library-aot-tests.yml

ilonatommy · 2024-06-11T10:17:51Z

/azp run runtime-wasm

azure-pipelines · 2024-06-11T10:18:11Z

Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy · 2024-06-11T12:10:35Z

LibraryTests_HybridGlobalization_AOT WasmTestOnNodeJS and WasmTestOnChrome

_buildAOTFunc publish/ProxyProjectForAOTOnHelix.proj /root/helix/work/workitem/uploads/xharness-output/AOTBuild.binlog /p:RunAOTCompilation=true ^&^& cd wasm_build/AppBundle ^&^& dotnet exec /root/helix/work/correlation/microsoft.dotnet.xharness.cli/9.0.0-prerelease.24277.1/tools/net8.0/any/Microsoft.DotNet.XHarness.CLI.dll wasm test --app=. --output-directory=/root/helix/work/workitem/uploads/xharness-output -s dotnet.native.js.symbols --symbol-patterns wasm-symbol-patterns.txt --symbolicator WasmSymbolicator.dll,Microsoft.WebAssembly.Internal.SymbolicatorWrapperForXHarness --timeout=00:30:00 --engine=NodeJS --engine-arg=--stack-trace-limit=1000 --engine-arg=--experimental-wasm-eh --js-file=test-main.js  --   --setenv=NPM_MODULES= --run WasmTestRunner.dll System.Xml.Linq.xNodeBuilder.Tests.dll  -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-103229-merge-01a097b651cc4d9d9b/WasmTestOnNodeJS-ST-System.Xml.Linq.xNodeBuilder.Tests/1/console.9acd24b4.log?helixlogtype=result

/root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(513,5): error : Specified Emscripten sdk at $(EMSDK_PATH)=/root/helix/work/correlation/build/emsdk/ is missing some paths: $(EmscriptenNodeToolsPath)=/root/helix/work/correlation/build/emsdk/node/bin/ . SDK is required for AOT'ing assemblies.

is #51746, so we cannot enable running them yet, I will have to block HybridGlobalization_AOT till it's resolved. But generally the PR serves its purpose.

Use fixed scenarios only when they are not passed.

8fae998

ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization labels Jun 10, 2024

ilonatommy self-assigned this Jun 10, 2024

ilonatommy requested a review from akoeplinger as a code owner June 10, 2024 15:15

akoeplinger reviewed Jun 10, 2024

View reviewed changes

eng/pipelines/common/templates/wasm-library-aot-tests.yml Outdated Show resolved Hide resolved

akoeplinger reviewed Jun 10, 2024

View reviewed changes

eng/pipelines/common/templates/wasm-library-aot-tests.yml Outdated Show resolved Hide resolved

Feedback.

935a441

Dummy change to trigger the CI.

acf237c

ilonatommy added 3 commits June 11, 2024 08:34

Fix: the indentation problem.

7c3fddd

Fix: syntax problem.

44bf7ac

Revert: syntax change did not help.

33d5ec9

ilonatommy closed this Jun 11, 2024

ilonatommy reopened this Jun 11, 2024

Fix: remove empty keyword

4dd5d6c

Fix

aaf265e

akoeplinger reviewed Jun 11, 2024

View reviewed changes

eng/pipelines/common/templates/wasm-library-aot-tests.yml Outdated Show resolved Hide resolved

String -> array.

7e72824

akoeplinger approved these changes Jun 11, 2024

View reviewed changes

Block.

60335b5

ilonatommy added the disabled-test The test is disabled in source code against the issue label Jun 11, 2024

build-analysis bot mentioned this pull request Jun 11, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

ilonatommy merged commit 5163901 into dotnet:main Jun 12, 2024

This was referenced Jun 26, 2024

[browser][hybridglobalization][aot] Assert.StartsWith cannot find a match #102373

Closed

Test HybridGlobalization with AOT on CI #104027

Closed

github-actions bot locked and limited conversation to collaborators Jul 27, 2024

Conversation

ilonatommy commented Jun 10, 2024

Uh oh!

ilonatommy commented Jun 10, 2024

Uh oh!

azure-pipelines bot commented Jun 10, 2024

Uh oh!

dotnet-policy-service bot commented Jun 10, 2024

Uh oh!

Uh oh!

Uh oh!

ilonatommy commented Jun 10, 2024

Uh oh!

azure-pipelines bot commented Jun 10, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

azure-pipelines bot commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

azure-pipelines bot commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

azure-pipelines bot commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

akoeplinger commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

azure-pipelines bot commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

azure-pipelines bot commented Jun 11, 2024

Uh oh!

Uh oh!

ilonatommy commented Jun 11, 2024

Uh oh!

azure-pipelines bot commented Jun 11, 2024

Uh oh!

ilonatommy commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ilonatommy commented Jun 11, 2024 •

edited

Loading