[QUIC] Add platform guard to IsSupported#103342
Merged
ManickaP merged 1 commit intodotnet:mainfrom Jun 18, 2024
Merged
Conversation
|
Note regarding the |
ghost
added
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This was referenced Jun 12, 2024
ManickaP
force-pushed
the
quic-platform-guard
branch
from
1ffd525 to
3e7cc3d
Compare
buyaa-n
approved these changes
Jun 17, 2024
Contributor
buyaa-n
left a comment
buyaa-n
left a comment
There was a problem hiding this comment.
Probably no need to add the attributes into generated files (QuicConnection.Unsupported.cs, QuicListener.Unsupported.cs), anyway if/when they regenerated the attributes will not be there.
CarnaViire
approved these changes
Jun 17, 2024
Member
Author
They're not generated though, their content is on PNSE exclusion list and these sources are used instead. |
Member
Author
|
/ba-g wasm failure reported here: #103623 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the
IsSupportedproperties not trigger the compiler warning about using unsupported API, in other words avoiding this:for a simple:
We might even try if we could get away with using the
QuicConnection.IsSupportedas a trimming guard (instead ofIsHttp3Supported()) in HTTP code.EDIT: Analyzer is in main.
PR as a draft for now since it depends on dotnet/roslyn-analyzers#7326