The mask of shift amount in IShiftOperators<byte, int, byte> should be 7#103900
Merged
tannergooding merged 5 commits intodotnet:mainfrom Dec 3, 2024
Merged
The mask of shift amount in IShiftOperators<byte, int, byte> should be 7#103900tannergooding merged 5 commits intodotnet:mainfrom
IShiftOperators<byte, int, byte> should be 7#103900tannergooding merged 5 commits intodotnet:mainfrom
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Member
|
This is also notably an issue with The intent had indeed been to correctly mask, which is being done in other operations but was missed for these ones. |
Contributor
Author
|
OK. I will wait for a conclusion before further action. |
This was referenced Jun 24, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Closed
Closed
This was referenced Jul 20, 2024
Member
|
@skyoxZ, just wanted to let you know that this is still on my radar. I need to create a |
tannergooding
added
breaking-change
tannergooding
removed
the
needs-breaking-change-doc-created
This was referenced Dec 3, 2024
Open
tannergooding
approved these changes
Dec 3, 2024
eduardo-vp
pushed a commit
to eduardo-vp/runtime
that referenced
this pull request
Dec 5, 2024
… be 7 (dotnet#103900) * The mask of shift amount in IShiftOperators<byte, int, byte> should be 7 * Fix mask of shift amount --------- Co-authored-by: Tanner Gooding <[email protected]>
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
… be 7 (dotnet#103900) * The mask of shift amount in IShiftOperators<byte, int, byte> should be 7 * Fix mask of shift amount --------- Co-authored-by: Tanner Gooding <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #103506