Fix trim warnings for base method implementing interface#104753
Merged
sbomer merged 9 commits intodotnet:mainfrom Jul 15, 2024
Merged
Fix trim warnings for base method implementing interface#104753sbomer merged 9 commits intodotnet:mainfrom
sbomer merged 9 commits intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
This was referenced Jul 12, 2024
Open
MichalStrehovsky
approved these changes
Jul 15, 2024
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell.
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/FlowAnnotations.cs
Outdated
Show resolved
Hide resolved
And left-over comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97676